fix to hide messageInputFragment when user has no restriction to write #4240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messageInputFragment was hidden by checkShowMessageInputView(), but it was immediately shown again by checkLobbyState() This fix will execute checkShowMessageInputView() inside checkLobbyState() in the correct order. Additionally, the check checkLobbyState() has to be already executed in GetCapabilitiesInitialLoadState as well as checkShowCallButtons() Otherwise the expected behavior would only be set after 30 seconds. An improvemnt for the future must be to improve the capabilities handling. Signed-off-by: Marcel Hibbe <[email protected]>
|
/backport to stable-20.0 |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4240-talk.apk |
rapterjet2004
approved these changes
Sep 19, 2024
rapterjet2004
deleted the
bugfix/4238/fixToHideMessageInputWhenNoRestriction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4238
The messageInputFragment was hidden by checkShowMessageInputView(), but it was immediately shown again by checkLobbyState()
This fix will execute checkShowMessageInputView() inside checkLobbyState() in the correct order.
Additionally, the check
checkLobbyState()
has to be already executed in
GetCapabilitiesInitialLoadState
as well as
checkShowCallButtons()
Otherwise the expected behavior would only be set after 30 seconds.
An improvemnt for the future must be to improve the capabilities handling.
🏁 Checklist
/backport to stable-xx.x